Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply saved query and modals for editing and saving a query #83

Merged
merged 2 commits into from Aug 23, 2023

Conversation

dkumiszhan
Copy link
Collaborator

No description provided.

@glaslos
Copy link
Member

glaslos commented Aug 20, 2023

just gave it a try: Saved a query with active flag not set, query listed as inactive. Couldn't set it to active using the edit modal. The Activate button made the query active. Pressing it again kept the query active. Couldn't deactivate the query using the form or the button.

@dkumiszhan
Copy link
Collaborator Author

just gave it a try: Saved a query with active flag not set, query listed as inactive. Couldn't set it to active using the edit modal. The Activate button made the query active. Pressing it again kept the query active. Couldn't deactivate the query using the form or the button.

I removed all usages of query.active field coming from the backend and store the active filter in local storage. The activate button should be working now.

Copy link
Member

@glaslos glaslos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glaslos glaslos merged commit cc1e375 into main Aug 23, 2023
2 checks passed
@glaslos glaslos deleted the feat/apply-query branch August 23, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants