bugfix/use :: instead of List for Constant

hongwei1 · Jun 12, 2024 · 53d4302 · 53d4302
1 parent 4b83ffd
commit 53d4302
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 30 deletions.
diff --git a/obp-api/src/main/scala/code/api/constant/constant.scala b/obp-api/src/main/scala/code/api/constant/constant.scala
@@ -62,36 +62,34 @@ object Constant extends MdcLoggable {
   final val SYSTEM_READ_TRANSACTIONS_BERLIN_GROUP_VIEW_ID = "ReadTransactionsBerlinGroup"
 
   //TODO, this need to be double check
-  final val ALL_SYSTEM_VIEWS_CREATED_FROM_BOOT = List(
-    SYSTEM_OWNER_VIEW_ID,
-    SYSTEM_AUDITOR_VIEW_ID,
-    SYSTEM_ACCOUNTANT_VIEW_ID,
-    SYSTEM_FIREHOSE_VIEW_ID,
-    SYSTEM_STANDARD_VIEW_ID,
-    SYSTEM_STAGE_ONE_VIEW_ID,
-    SYSTEM_MANAGE_CUSTOM_VIEWS_VIEW_ID,
-    SYSTEM_READ_ACCOUNTS_BASIC_VIEW_ID,
-    SYSTEM_READ_ACCOUNTS_DETAIL_VIEW_ID,
-    SYSTEM_READ_BALANCES_VIEW_ID,
-    SYSTEM_READ_TRANSACTIONS_BASIC_VIEW_ID,
-    SYSTEM_READ_TRANSACTIONS_DEBITS_VIEW_ID,
-    SYSTEM_READ_TRANSACTIONS_DETAIL_VIEW_ID,
-    SYSTEM_READ_ACCOUNTS_BERLIN_GROUP_VIEW_ID,
-    SYSTEM_READ_BALANCES_BERLIN_GROUP_VIEW_ID,
-    SYSTEM_READ_TRANSACTIONS_BERLIN_GROUP_VIEW_ID
-  )
+  final val ALL_SYSTEM_VIEWS_CREATED_FROM_BOOT = 
+    SYSTEM_OWNER_VIEW_ID::
+    SYSTEM_AUDITOR_VIEW_ID::
+    SYSTEM_ACCOUNTANT_VIEW_ID::
+    SYSTEM_FIREHOSE_VIEW_ID::
+    SYSTEM_STANDARD_VIEW_ID::
+    SYSTEM_STAGE_ONE_VIEW_ID::
+    SYSTEM_MANAGE_CUSTOM_VIEWS_VIEW_ID::
+    SYSTEM_READ_ACCOUNTS_BASIC_VIEW_ID::
+    SYSTEM_READ_ACCOUNTS_DETAIL_VIEW_ID::
+    SYSTEM_READ_BALANCES_VIEW_ID::
+    SYSTEM_READ_TRANSACTIONS_BASIC_VIEW_ID::
+    SYSTEM_READ_TRANSACTIONS_DEBITS_VIEW_ID::
+    SYSTEM_READ_TRANSACTIONS_DETAIL_VIEW_ID::
+    SYSTEM_READ_ACCOUNTS_BERLIN_GROUP_VIEW_ID::
+    SYSTEM_READ_BALANCES_BERLIN_GROUP_VIEW_ID::
+    SYSTEM_READ_TRANSACTIONS_BERLIN_GROUP_VIEW_ID :: Nil
 
-  final val ALL_SYSTEM_VIEWS_CREATED_FROM_CBS = List(
-    SYSTEM_OWNER_VIEW_ID,
-    SYSTEM_ACCOUNTANT_VIEW_ID,
-    SYSTEM_AUDITOR_VIEW_ID,
-    SYSTEM_STAGE_ONE_VIEW_ID,
-    SYSTEM_STANDARD_VIEW_ID,
-    SYSTEM_MANAGE_CUSTOM_VIEWS_VIEW_ID,
-    SYSTEM_READ_ACCOUNTS_BERLIN_GROUP_VIEW_ID,
-    SYSTEM_READ_BALANCES_BERLIN_GROUP_VIEW_ID,
-    SYSTEM_READ_TRANSACTIONS_BERLIN_GROUP_VIEW_ID
-  )
+  final val ALL_SYSTEM_VIEWS_CREATED_FROM_CBS = 
+    SYSTEM_OWNER_VIEW_ID::
+    SYSTEM_ACCOUNTANT_VIEW_ID::
+    SYSTEM_AUDITOR_VIEW_ID::
+    SYSTEM_STAGE_ONE_VIEW_ID::
+    SYSTEM_STANDARD_VIEW_ID::
+    SYSTEM_MANAGE_CUSTOM_VIEWS_VIEW_ID::
+    SYSTEM_READ_ACCOUNTS_BERLIN_GROUP_VIEW_ID::
+    SYSTEM_READ_BALANCES_BERLIN_GROUP_VIEW_ID::
+    SYSTEM_READ_TRANSACTIONS_BERLIN_GROUP_VIEW_ID :: Nil
 
   //These are the default incoming and outgoing account ids. we will create both during the boot.scala.
   final val INCOMING_SETTLEMENT_ACCOUNT_ID = "OBP-INCOMING-SETTLEMENT-ACCOUNT"    

diff --git a/obp-api/src/main/scala/code/api/util/APIUtil.scala b/obp-api/src/main/scala/code/api/util/APIUtil.scala
@@ -148,7 +148,7 @@ object APIUtil extends MdcLoggable with CustomJsonFormats{
   val DateWithMonthFormat = new SimpleDateFormat(DateWithMonth)
   val DateWithDayFormat = new SimpleDateFormat(DateWithDay)
   val DateWithSecondsFormat = new SimpleDateFormat(DateWithSeconds)
-  val DateWithMsFormat = new SimpleDateFormat(DateWithMs)
+  lazy val DateWithMsFormat = new SimpleDateFormat(DateWithMs)
   val DateWithMsRollbackFormat = new SimpleDateFormat(DateWithMsRollback)
 
   val DateWithYearExampleString: String = "1100"