POC: add support for IntegrationTestScenario v2alpha1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
hongweiliu17
commented
Apr 4, 2023
•
hongweiliu17
commented
- Add v2alpha1 as storage version
- Add ResolverRef with Resolver(String) and Params([]v2alpha1.PipelineParameter, use v2alpha1.PipelineParameter as a workaround because an issue of using Params([]tektonv1beta1.Param) has not been fixed, see unittest https://github.com/redhat-appstudio/integration-service/actions/runs/4602777005/jobs/8132117159?pr=139#step:18:56 in Add new version v1beta1 to integrationtestscenario to support Tekton Resolver konflux-ci/integration-service#139) under IntegrationTestScenario.Spec
- Add webhook and conversion to convert between different versions
- Update the api version to v2alpha1 in controller and files
hongweiliu17
changed the title
* Add v2alpha1 as storage version * Add ResolverRef with Resolver and Params under IntegrationTestScenario.Spec * Add webhook and conversion to convert between different versions * Update the api version to v2alpha1 in controller and files Signed-off-by: Hongwei Liu <hongliu@github.com>
hongweiliu17
force-pushed
the
api_conversion
branch
from
05fdde5
to
ac59e1a
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
- Coverage 71.68% 71.20% -0.48%
==========================================
Files 25 29 +4
Lines 2320 2358 +38
==========================================
+ Hits 1663 1679 +16
- Misses 503 526 +23
+ Partials 154 153 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.