Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): remove "request" package #329

Merged
merged 3 commits into from
Mar 26, 2023
Merged

fix(deps): remove "request" package #329

merged 3 commits into from
Mar 26, 2023

Conversation

azu
Copy link
Member

@azu azu commented Mar 26, 2023 •
edited
Loading

@azu azu linked an issue Mar 26, 2023 that may be closed by this pull request
Remove "request" package #328
Closed
@azu azu added the Type: Security Vulnerability disclosure or Fixing security issue label Mar 26, 2023
azu
azu commented Mar 26, 2023
View reviewed changes
packages/honkit/src/utils/fs.ts
// create dest dir if not exists
const destDir = path.dirname(destFilePath);
await fs.promises.mkdir(destDir, { recursive: true });
const d = Promise.defer();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use native Promise

@azu azu merged commit 82ba754 into master Mar 26, 2023
@azu azu deleted the 328-remove-request-package branch March 26, 2023 06:31
@Phin-Kurniawan
Copy link

so how to fix this issue
=== npm audit security report ===

                             Manual Review
         Some vulnerabilities require your attention to resolve

      Visit https://go.npm.me/audit-guide for additional guidance

Moderate Server-Side Request Forgery in Request

Package request

Patched in No patch available

Dependency of firebase-tools

Path firebase-tools > request

More info GHSA-p8p7-x288-28g6

Moderate Server-Side Request Forgery in Request

Package request

Patched in No patch available

Dependency of request

Path request

More info GHSA-p8p7-x288-28g6

found 2 moderate severity vulnerabilities in 869 scanned packages
2 vulnerabilities require manual review. See the full report for details.

@azu
Copy link
Member Author

azu commented Apr 3, 2023

Dependency of firebase-tools

Path firebase-tools > request

Your dependendcies has firebase-tools that use request.
It is not related to HonKit

@honkit honkit locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Security Vulnerability disclosure or Fixing security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "request" package
2 participants
@azu @Phin-Kurniawan