fix(ssg): fixed isDynamicRoute and ssgParams matter (#2006)

* fix(ssg): fixed `isDynamicRoute` and `ssgParams` matter * denoify
honojs · Jan 17, 2024 · 19259d3 · 19259d3
1 parent f232483
commit 19259d3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/deno_dist/helper/ssg/index.ts b/deno_dist/helper/ssg/index.ts
@@ -102,14 +102,15 @@ export const fetchRoutesContent = async <
   const baseURL = 'http://localhost'
 
   for (const route of inspectRoutes(app)) {
-    if (route.isMiddleware || isDynamicRoute(route.path)) continue
+    if (route.isMiddleware) continue
 
     // GET Route Info
     const thisRouteBaseURL = new URL(route.path, baseURL).toString()
     const forGetInfoURLRequest = new Request(thisRouteBaseURL) as AddedSSGDataRequest
     await app.fetch(forGetInfoURLRequest)
 
     if (!forGetInfoURLRequest.ssgParams) {
+      if (isDynamicRoute(route.path)) continue
       forGetInfoURLRequest.ssgParams = [{}]
     }
 

diff --git a/src/helper/ssg/index.ts b/src/helper/ssg/index.ts
@@ -101,14 +101,15 @@ export const fetchRoutesContent = async <
   const baseURL = 'http://localhost'
 
   for (const route of inspectRoutes(app)) {
-    if (route.isMiddleware || isDynamicRoute(route.path)) continue
+    if (route.isMiddleware) continue
 
     // GET Route Info
     const thisRouteBaseURL = new URL(route.path, baseURL).toString()
     const forGetInfoURLRequest = new Request(thisRouteBaseURL) as AddedSSGDataRequest
     await app.fetch(forGetInfoURLRequest)
 
     if (!forGetInfoURLRequest.ssgParams) {
+      if (isDynamicRoute(route.path)) continue
       forGetInfoURLRequest.ssgParams = [{}]
     }