test(deno): add runtime_tests/deno/deno.json in order to allow `docum…

…ent`, `Element`, etc.
honojs · Jan 15, 2024 · caba00e · caba00e
1 parent 41e533d
commit caba00e
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -46,7 +46,7 @@ jobs:
       - uses: denoland/setup-deno@v1
         with:
           deno-version: v1.x
-      - run: env NAME=Deno deno test --allow-read --allow-env runtime_tests/deno
+      - run: env NAME=Deno deno test --allow-read --allow-env -c runtime_tests/deno/deno.json runtime_tests/deno
       - run: deno test -c runtime_tests/deno-jsx/deno.precompile.json runtime_tests/deno-jsx
       - run: deno test -c runtime_tests/deno-jsx/deno.react-jsx.json runtime_tests/deno-jsx
 

diff --git a/deno_dist/helper/css/index.ts b/deno_dist/helper/css/index.ts
@@ -216,13 +216,10 @@ export const createCssContext = ({ id }: { id: Readonly<string> }) => {
     }
 
     const addClassNameToContext: HtmlEscapedCallback = ({ context, phase }) => {
-      /* eslint-disable @typescript-eslint/ban-ts-comment */
       if (phase === HtmlEscapedCallbackPhase.BeforeDom) {
-        // @ts-ignore XXX: "document" is required `"lib": ["dom"]` in tsconfig, but user may not use it
         const styleSheets = document.styleSheets
         for (let i = 0; i < styleSheets.length; i++) {
           const sheet = styleSheets[i]
-          // @ts-ignore XXX: "Element" is required `"lib": ["dom"]` in tsconfig, but user may not use it
           if ((sheet.ownerNode as Element)?.id === id) {
             if (!sheet.cssRules?.[0]?.cssText?.includes(thisSelector)) {
               sheet.insertRule(`.${thisSelector}{${thisStyleString}}`)
@@ -232,7 +229,6 @@ export const createCssContext = ({ id }: { id: Readonly<string> }) => {
         }
         return
       }
-      /* eslint-enable @typescript-eslint/ban-ts-comment */
 
       if (!contextMap.get(context)) {
         contextMap.set(context, [{}, {}])

diff --git a/runtime_tests/deno-jsx/deno.precompile.json b/runtime_tests/deno-jsx/deno.precompile.json
@@ -1,7 +1,8 @@
 {
   "compilerOptions": {
     "jsx": "precompile",
-    "jsxImportSource": "hono/jsx"
+    "jsxImportSource": "hono/jsx",
+    "lib": ["deno.ns", "dom"]
   },
   "imports": {
     "hono/jsx/jsx-runtime": "../../deno_dist/jsx/jsx-runtime.ts",

diff --git a/runtime_tests/deno-jsx/deno.react-jsx.json b/runtime_tests/deno-jsx/deno.react-jsx.json
@@ -1,7 +1,8 @@
 {
   "compilerOptions": {
     "jsx": "react-jsx",
-    "jsxImportSource": "hono/jsx"
+    "jsxImportSource": "hono/jsx",
+    "lib": ["deno.ns", "dom"]
   },
   "imports": {
     "hono/jsx/jsx-runtime": "../../deno_dist/jsx/jsx-runtime.ts",

diff --git a/runtime_tests/deno/deno.json b/runtime_tests/deno/deno.json
@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "lib": ["deno.ns", "dom"]
+  }
+}
diff --git a/src/helper/css/index.ts b/src/helper/css/index.ts
@@ -216,13 +216,10 @@ export const createCssContext = ({ id }: { id: Readonly<string> }) => {
     }
 
     const addClassNameToContext: HtmlEscapedCallback = ({ context, phase }) => {
-      /* eslint-disable @typescript-eslint/ban-ts-comment */
       if (phase === HtmlEscapedCallbackPhase.BeforeDom) {
-        // @ts-ignore XXX: "document" is required `"lib": ["dom"]` in tsconfig, but user may not use it
         const styleSheets = document.styleSheets
         for (let i = 0; i < styleSheets.length; i++) {
           const sheet = styleSheets[i]
-          // @ts-ignore XXX: "Element" is required `"lib": ["dom"]` in tsconfig, but user may not use it
           if ((sheet.ownerNode as Element)?.id === id) {
             if (!sheet.cssRules?.[0]?.cssText?.includes(thisSelector)) {
               sheet.insertRule(`.${thisSelector}{${thisStyleString}}`)
@@ -232,7 +229,6 @@ export const createCssContext = ({ id }: { id: Readonly<string> }) => {
         }
         return
       }
-      /* eslint-enable @typescript-eslint/ban-ts-comment */
 
       if (!contextMap.get(context)) {
         contextMap.set(context, [{}, {}])