Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(context): add status to TypedResponse #1403

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat(context): add status to TypedResponse #1403

merged 2 commits into from
Sep 5, 2023

Conversation

ThatOneBro
Copy link
Contributor

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

About the PR

Very simple, just adds a status prop to TypedResponse like mentioned in the issue.

Closes #1323.

@yusukebe yusukebe changed the base branch from main to next September 5, 2023 06:48
@yusukebe yusukebe changed the base branch from next to main September 5, 2023 06:48
@yusukebe yusukebe changed the base branch from main to next September 5, 2023 06:57
@yusukebe
Copy link
Member

yusukebe commented Sep 5, 2023

Hi @ThatOneBro !

LGTM! This is a new feature, so I'll merge it into the next branch to release as a minor version. Thanks!

@yusukebe yusukebe merged commit 8cea5bc into honojs:next Sep 5, 2023
10 checks passed
@yusukebe yusukebe mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add status to TypedResponse
2 participants
@ThatOneBro @yusukebe