-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(vitest): replace jest
with vitest
#1404
test(vitest): replace jest
with vitest
#1404
Conversation
Great work! I've tested this in my local machine, it's fast! I'll take a look about the Fastly issue. Thanks! |
Hi @ThatOneBro, I think reproducing the runtime environment is important. As of now, we've successfully emulated the Fastly environment with What do you think about this? |
Hey @yusukebe, that makes sense to me. I'll make that change tonight so we can merge this. Keeping |
Thanks! |
No problem, @yusukebe! I added |
Hi @ThatOneBro ! Perfect! Let's go with it. Thanks Derrick! |
* test(vitest): replace `jest` with `vitest` for core tests * test(fastly): `jest` -> `vitest`, correct env for fastly * test(jest): remove `jest-environment-miniflare` as dep * test(lagon): configure `lagon` tests to run on `vitest` * test(lambda): `jest` -> `vitest` * test(lambda-edge): `jest` -> `vitest` * test(node): `jest` -> `vitest` * test(wrangler): `jest` -> `vitest` * chore(deps): remove `jest` and `ts-jest` from deps * test(vitest): add `yarn coverage` for checking coverage * test(fastly): fix check for `globalThis.crypto` * test(handler): fix stray `.only` * test(lagon): change env file back to original path * test(fastly): go back to `jest` until `vitest` has support for fastly env * test(fastly): remove hack for the `crypto` global from the test
Author should do the followings, if applicable
yarn denoify
to generate files for DenoWhat this PR does
Replaces
jest
withvitest
and cleans up dependencies.I did notice one failing test inEDIT: Tests not failing on CI, so seems ok.lagon
suite, but I think it's unrelated to this PR.Closes #1390.
TODO
EDIT: One last test failing on
Fastly Compute@Edge
...Fastly