Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(req): deprecate c.req.headers (not c.req.header) and others #1410

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Sep 5, 2023

This PR makes these properties in HonoRequest deprecated:

get headers() {
  return this.raw.headers
}
get body() {
  return this.raw.body
}
get bodyUsed() {
  return this.raw.bodyUsed
}
get integrity() {
  return this.raw.integrity
}
get keepalive() {
  return this.raw.keepalive
}
get referrer() {
  return this.raw.referrer
}
get signal() {
  return this.raw.signal
}

These will be obsolete in v4.

Close #1399

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

@yusukebe yusukebe merged commit aee2093 into next Sep 5, 2023
10 checks passed
@yusukebe yusukebe deleted the feat/deprecate-req-headers-others branch September 5, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant