cookie parsing improvements #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeys089
force-pushed
the
cookie-improvements
branch
from
34c6c0b
to
eb14a88
Compare
jkeys089
force-pushed
the
cookie-improvements
branch
from
eb14a88
to
f86af71
Compare
|
Cool! Looks good. Thanks @jkeys089 ! |
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Feb 7, 2024
honojs/hono#1428 improved cookie parsing and addresses the `Cannot read properties of undefined (reading 'split')` issues we're seeing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author should do the followings, if applicable
yarn denoifyto generate files for DenoImprovements
crypto.subtle.verifyinstead of comparing strings)