Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(basic-auth): basic-auth middleware #28

Merged
merged 3 commits into from
Jan 7, 2022
Merged

feat(basic-auth): basic-auth middleware #28

merged 3 commits into from
Jan 7, 2022

Conversation

metrue
Copy link
Contributor

@metrue metrue commented Jan 7, 2022 •
edited

Close #26

@metrue metrue changed the title feat(basic-auth): basic-auth middleware WIP: feat(basic-auth): basic-auth middleware Jan 7, 2022
@metrue metrue changed the title WIP: feat(basic-auth): basic-auth middleware feat(basic-auth): basic-auth middleware Jan 7, 2022
yusukebe
yusukebe reviewed Jan 7, 2022
View reviewed changes
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I have no complaints about implementation.
Commented small things about example script.

example/basic/index.js Outdated Show resolved Hide resolved
example/basic/index.js Show resolved Hide resolved
@metrue
Copy link
Contributor Author

metrue commented Jan 7, 2022

@yusukebe

Let me clean up the no need changes in this PR first, will let you know when it's ready for review.

@metrue metrue requested a review from yusukebe January 7, 2022 08:41
@metrue
Copy link
Contributor Author

metrue commented Jan 7, 2022

@yusukebe It's ready for review now.

yusukebe
yusukebe approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@yusukebe yusukebe merged commit cb4f3d6 into honojs:master Jan 7, 2022
@yusukebe yusukebe mentioned this pull request Jan 7, 2022
Closed
60 tasks
@metrue metrue deleted the basic-auth branch January 7, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusukebe yusukebe yusukebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic Auth
2 participants
@metrue @yusukebe