Export md5 function in src/utils/crypto.ts
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export an additional `md5` function in the crypto utility.
Useful when working with R2 and providing a MD5 hash for verification.
```
import { md5 } from "hono/utils/crypto";
...
const md5Digest = md5(body);
const object = await bucket.put(key, body, {md5: md5Digest});
```
|
Hi @erhlee-bird ! Thank you for your PR. It's OK to export the |
Add a test for 'md5' crypto utility function.
|
Added the test and confirmed that it passes locally. Thanks for responding so quickly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export an additional
md5function in the crypto utility.Useful when working with R2 and providing a MD5 hash for verification.
It is worth noting, however, that "MD5 is not part of the WebCrypto standard but is supported in Cloudflare Workers for interacting with legacy systems that require MD5." 1