perf(jsx): JSX performance improvement #444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #439.
Changes
There are no changes to the external specification in this PR, and we can continue to stringify templates with
(<p>text</p>).toString()
. However, there are some changes in the internal structure.jsx
returnsJSXNode
instead ofHtmlEscapedString
Previously, upon calling
jsx
, basic stringification was completed and anHtmlEscapedString
object was returned, but with this PR, a data-wrappedJSXNode
is returned upon callingjsx
. The stringification is done attoString()
call.Discussion
With this PR,
escape
defined in utils/html is no longer used inside the hono repository. (OnlyescapeToBuffer
is used.)The
escape
function is fast enough and convenient for hono users to use in their applications, but depending on policy, it could be removed as unnecessary.Benchmark