feat: Add new shortcuts for request/response #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metrue
reviewed
Jan 25, 2022
src/middleware/default.ts
Outdated
| @@ -6,6 +6,10 @@ export const defaultMiddleware = async (c: Context, next: Function) => { | |||
| const url = new URL(c.req.url) | |||
| return url.searchParams.get(key) | |||
| } | |||
| c.req.params = c.req.param // alias | |||
There was a problem hiding this comment.
Why we just make ctx.req.params at the first place to avoid this alias?
There was a problem hiding this comment.
I see, that is better to make the alias after this: https://github.com/yusukebe/hono/pull/62/files#diff-fef0c99deaa99c63dde9a9af2451ae5281a68e92c338218d644a08b358878245R131
There was a problem hiding this comment.
Why we have both params and param in a Request, is possible to make it only params or param?
There was a problem hiding this comment.
Yes, we make it param only because params is just for backward compatibility and that we have both may cause confusion.
yusukebe
changed the title
yusukebe
added a commit
that referenced
this pull request
Jan 26, 2022
* Add new shortcuts for request/response * We have only `param`, we can not use `params` * Update readme * tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new shortcuts for Requests:
Add new shortcuts for Response: