feat: $ prefix named file as island component
#171
Merged
+92
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @usualoma ! What do you think about this? If it's okay, please review it! |
usualoma
reviewed
May 8, 2024
src/vite/island-components.ts
Outdated
| */ | ||
| export function matchIslandComponentId(id: string) { | ||
| return id.match( | ||
| /(\/islands\/.+?\.tsx$)|(\/routes\/.*\_[a-zA-Z0-9[-]+\.island\.tsx$)|(\/routes.*\/\$[a-zA-Z0-9[-]+\.tsx$)/ |
There was a problem hiding this comment.
Is it intended that there is no / under routes ? If not, I think it should be added.
Suggested change
| /(\/islands\/.+?\.tsx$)|(\/routes\/.*\_[a-zA-Z0-9[-]+\.island\.tsx$)|(\/routes.*\/\$[a-zA-Z0-9[-]+\.tsx$)/ | |
| /(\/islands\/.+?\.tsx$)|(\/routes\/.*\_[a-zA-Z0-9[-]+\.island\.tsx$)|(\/routes\/.*\/\$[a-zA-Z0-9[-]+\.tsx$)/ |
We might also want to take this opportunity to review our existing regular expressions as well. I think I can summarize as follows
return id.match(
/\/islands\/.+?\.tsx$|\/routes\/(?:.*\/)?(?:\_[a-zA-Z0-9-]+\.island\.tsx$|\$[a-zA-Z0-9-]+\.tsx$)/
)
There was a problem hiding this comment.
Is it intended that there is no
/underroutes? If not, I think it should be added.
I'd like it to match /routes/$counter.tsx.
Is
[necessary?
Exactly, no! It's not necessary. It's (maybe my) fault.
return id.match(
/\/islands\/.+?\.tsx$|\/routes\/(?:.*\/)?(?:\_[a-zA-Z0-9-]+\.island\.tsx$|\$[a-zA-Z0-9-]+\.tsx$)/
)Great! This will match /routes/$counter.tsx. I'll change the regex to yours and add some tests. I'll add you as a co-author for this PR.
Co-authored-by: Taku Amano <taku@taaas.jp>
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the component file whose name has
$as a prefix, like/app/routes/dir/$counter.tsx, will be treated as an island component.Before this PR, the filenames which are island components are below:
/islands-/islands/conter.tsx.island.tsxsuffix -/app/routes/dir/_counter.island.tsxFrom my experience using HonoX, it's sometimes easy to handle if the island component is in the same directory with the route file. So the
2is better. But I'd make it a simpler and shorter name.$prefix -/app/routes/dir/$counter.tsxWhy
$- this is just my taste, but I think it's easy to understand.I'll work on #159 after merging this PR.