Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vercel page #297

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Update Vercel page #297

merged 2 commits into from
Apr 7, 2024

Conversation

Armster15
Copy link
Contributor

Hello, and thanks for Hono! I've made two changes to the Vercel docs:

  1. I added a TS type to the exported config object that some of the API routes use
  2. To address 500 responses when including body payload in any request using @hono/node-server/vercel node-server#84, I updated the pages router Node.js example to have the bodyParser setting turned off. Based on my manual testing, this issue only affects the pages router API routes running on Node.js: the app router as a whole and page router edge API routes are not affected and as such don't need bodyParser turned off.

See honojs/node-server#84
Based on manual testing, this only affects the Node js runtime on the pages router: the app router as a whole and edge API routes in the pages router are unaffected.
@yusukebe
Copy link
Member

yusukebe commented Apr 7, 2024

@Armster15

Thanks! Great. I'll merge this now.

@yusukebe yusukebe merged commit b953af3 into honojs:main Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants