Don't persist in a create block when reading for validation. Fixes #1…

…372.
honwlee · Oct 23, 2011 · 184376b · 184376b
1 parent cc9d285
commit 184376b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,8 @@ For instructions on upgrading to newer versions, visit
 
 * \#1373 Warn if a scope overrides another scope.
 
+* \#1372 Never persist when binding inside of a read attribute for validation.
+
 * \#1364 Fixed reloading of documents with non bson object id ids.
 
 * \#1360 Fixed performance of Mongoid's observer instantiation by hooking into

diff --git a/lib/mongoid/relations/referenced/many.rb b/lib/mongoid/relations/referenced/many.rb
@@ -33,7 +33,7 @@ def <<(*args)
             args.flatten.each do |doc|
               next unless doc
               append(doc)
-              doc.save if persistable?
+              doc.save if persistable? && !doc.validated?
             end
           end
         end

diff --git a/lib/mongoid/validations.rb b/lib/mongoid/validations.rb
@@ -44,7 +44,9 @@ def exit_validate
     # @since 2.0.0.rc.1
     def read_attribute_for_validation(attr)
       if relations[attr.to_s]
+        begin_validate
         relation = send(attr)
+        exit_validate
         relation.do_or_do_not(:in_memory) || relation
       else
         send(attr)