-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humane test optput #9
Conversation
@@ -62,6 +63,7 @@ | |||
(karma-result! result))) | |||
|
|||
(defmethod cljs.test/report [::karma :fail] [m] | |||
(println m) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to contain correct map now (#8 (comment))
This pr just contains initial work - I'll probably continue on the weekend |
Great! Thank you. I'm just working on diff prototype https://github.com/honzabrecka/karma-reporter/tree/diff You can try with: (deftest failing-test
(is (= (inc 1) (inc 2) (inc 3)))
(is (= {:x [4] :a [1 3]}
{:a [1 2] :y [6] :x [4]}))
(is (true? (= true false)) "Whoops!")
(is (= (range 30) (range 1 50)) (str "Let me add in something\nfancy here: " {:a 1234}))
(is (> 1 2))) |
so... now it works, except the output is not very nice
because report- function doesn't return string, but does printing... I'll check what to do about this (probably pr to https://github.com/pjstadig/humane-test-output where report- will call some function which will return string and then it'll print it - we could than use the function returning the string instead of calling report-) |
it seems that with-out-str did the trick (I am not very experienced with clojure[script]). Is it mergeable now? |
Thank you for your work, but I decided to came up with custom output/diff format. |
No description provided.