Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadedCommentForm - title field label doesn't get translated #22

Closed
sq9mev opened this issue Jan 31, 2011 · 3 comments
Closed

ThreadedCommentForm - title field label doesn't get translated #22

sq9mev opened this issue Jan 31, 2011 · 3 comments

Comments

@sq9mev
Copy link

sq9mev commented Jan 31, 2011

Solution is (forms.py):
def init(self, target_object, parent=None, data=None, initial=None):
self.base_fields.insert(
self.base_fields.keyOrder.index('comment'), 'title',
forms.CharField(
label = _('Title'),
required=False,
max_length=getattr(settings, 'COMMENTS_TITLE_MAX_LENGTH', 255)
)
)

@honzakral
Copy link
Owner

title field label doesn't get translated Closed by 6f97065

Thanks sq9mev

@jonlesser
Copy link

The original solution from sq9mev works for me, but the committed change does not. I am getting a "KeyError at /comments/post/ 'title' " for line 33:

d['title'] = self.cleaned_data['title']

rbas in issue #25 is having the same problem (https://github.com/ericflo/django-threadedcomments/issues#issue/25) and he has a fix here rbas@b3b7b3e

@qiemem
Copy link

qiemem commented May 11, 2011

I'm having the same problem as jonlesser; self.cleaned_data doesn't appear to have the key 'title'. Reopen or new issue?

JordanReiter pushed a commit to JordanReiter/django-threadedcomments that referenced this issue Nov 24, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants