Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix threaded comments html #54

Merged
merged 1 commit into from
Apr 13, 2015
Merged

Conversation

Lab43
Copy link
Contributor

@Lab43 Lab43 commented Feb 28, 2014

This fixes issue #53 for me.

I changed this:

{% ifchanged comment.parent_id %}{% else %}
    </li>
{% endifchanged %}

{% if not comment.open and not comment.close %}
    </li>
{% endif %}

{% if comment.open %}
    <ul>
{% endif %}

to this:

{% if comment.open %}
    <ul>
{% else %}
    </li>
{% endif %}

I'm not sure what the reason was for the more complex logic before, but simplifying this has worked in every case I have tested so far.

vdboor added a commit that referenced this pull request Apr 13, 2015
@vdboor vdboor merged commit 6457bdf into honzakral:master Apr 13, 2015
@vdboor
Copy link
Collaborator

vdboor commented Apr 13, 2015

Thanks for looking into this! Sorry for the long delay until merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants