Fix invalid state, which happen if signals raise exception #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2014 17:59
|
I wonder, won't it work if the whole |
| if self.submit_date is None: # for comment save | ||
| self.submit_date = timezone.now() | ||
| Comment.objects.bulk_create([self]) | ||
| c = Comment.objects.latest("id") |
There was a problem hiding this comment.
this is by no means safe, it is a race condition
|
This is not a valid fix, it introduces several other issues, not to mention raw SQL. Proper handling of this is to encourage use of transaction middleware. |
|
Indeed. This needs to be solved in a better way. |
|
I am having the same problem here, anyone fixed it yet ? |
|
This fix is breaking ajax when replying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.