fixed mysql index issue on tree_path #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahko
force-pushed
the
fix-mysql-tree_path-index
branch
from
26e5256
to
d4f88c1
Compare
vdboor
added a commit
that referenced
this pull request
Jun 18, 2015
fixed mysql index issue on tree_path
| # Adding model 'ThreadedComment' | ||
| db.create_table('threadedcomments_comment', ( | ||
| ('comment_ptr', self.gf('django.db.models.fields.related.OneToOneField')(to=orm['comments.Comment'], unique=True, primary_key=True)), | ||
| ('title', self.gf('django.db.models.fields.TextField')(blank=True)), | ||
| ('parent', self.gf('django.db.models.fields.related.ForeignKey')(default=None, related_name='children', null=True, blank=True, to=orm['threadedcomments.ThreadedComment'])), | ||
| ('last_child', self.gf('django.db.models.fields.related.ForeignKey')(to=orm['threadedcomments.ThreadedComment'], null=True, blank=True)), | ||
| ('tree_path', self.gf('django.db.models.fields.CharField')(db_index=True, max_length=500)), | ||
| ('tree_path', self.gf('django.db.models.fields.CharField')(db_index=is_index, max_length=500)), |
There was a problem hiding this comment.
Why have this option while you have db_index=False in other places?
That seems to contradict itself.
There was a problem hiding this comment.
db_index=False only when the connection.vendor == 'mysql' otherwise you still will get an error on the migrations for new installations.
we can't just drop the index in the first migration because we need to support existing installations and new ones, so if we drop the index in the initial migration the index still will be there for existing installations.
let me know if that makes sense..
|
Sorry, I merged too soon. I've unmerged it, because I have a few questions about it.. Can you look into this? |
vdboor
added a commit
that referenced
this pull request
Jun 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this solves #65