Query paramters #23
Merged
Query paramters #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
gr2m
force-pushed
the
query-parameters
branch
from
d5886de
to
68d5f00
Compare
|
I’ll merge it it not make hoodiehq/hoodie-account-server#83 easier to get done, but if there are any objections / suggestions please let’s address them in follow up issues / PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @patriciagarcia pointed out in hoodiehq/hoodie-account-server#83, we currently do not specify error handling for invalid ?include parameter values. Instead of defining that for all resources & all requests, I think we can simply reference that JSON API instead. That will even reduce the current specification, as we do not need extra specification for things like
GET /session?include=account.profile, as this can be derived from the JSON API specification.