Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass serversecret first #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

pass serversecret first #8

wants to merge 3 commits into from

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Dec 25, 2015

closes #6

@gr2m
docs(README): pass serversecret first
46779bd
@gr2m
test: pass serversecret first
3bf331d
@gr2m
fix: pass serversecret first
9e2eb23 
BREAKING CHANGE:

before, the order of arguments was username, usersalt, serversecret, timestamp. Now, serversecret gets passed first:

```js
var sessionId = calculateSessionId(serversecret, username, usersalt, timestamp)
```
@gr2m gr2m mentioned this pull request Dec 25, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change order of arguments
1 participant
@gr2m