Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] rename /hoodie/bundle.js route to /hoodie/client.js #89

Closed
gr2m opened this issue Jan 11, 2016 · 4 comments
Closed

[next] rename /hoodie/bundle.js route to /hoodie/client.js #89

gr2m opened this issue Jan 11, 2016 · 4 comments

Comments

@gr2m
Copy link
Member

gr2m commented Jan 11, 2016

We talk about about "Hoodie client" and it will be mentioned a lot in the documentation, also the main repository is hoodie-client. So it would be more consistent to have the route where the Hoodie client is served /hoodie/client.js.

Note that /hoodie/client.js is not serving hoodie-client 1:1. hoodie-client returns a Hoodie constructor, /hoodie/client.js returns an instance of Hoodie with options passed in.

Any thoughts?

@boennemann @christophwitzko @janl
@varjmes
Copy link

varjmes commented Jan 11, 2016

Sounds good to me, it make sense even if it's not a 1:1.

@HipsterBrown
Copy link

Makes sense to keep it in sync with the current documentation, especially since "bundle" sounds a lot more related to Browserify than Hoodie. 1:1 FTW. 👍

@boennemann
Copy link
Member

We talk about about "Hoodie client" and it will be mentioned a lot in the documentation, also the main repository is hoodie-client. So it would be more consistent to have the route where the Hoodie client is served /hoodie/client.js.

+1

Note that /hoodie/client.js is not serving hoodie-client 1:1. hoodie-client returns a Hoodie constructor, /hoodie/client.js returns an instance of Hoodie with options passed in.

Currently it is the pre-built hoodie-client though.

@gr2m gr2m mentioned this issue Jan 18, 2016
Closed
@gr2m
Copy link
Member Author

gr2m commented Jan 18, 2016

it’s decided then, let’s do it: hoodiehq/hoodie-server#459

@gr2m gr2m closed this as completed Jan 18, 2016
gr2m added a commit to hoodiehq/hoodie-server that referenced this issue Feb 27, 2016
@gr2m
WIP - /hoodie/bundle.js is now /hoodie/client.js
ea18338 
hoodiehq/discussion#89

* * *

This commit was sponsored by Neighbourhoodie

You can hire Neighbourhoodie for all your
Hoodie / CouchDB / Offline First needs
http://go.hood.ie/thehoodiefirm
gr2m added a commit to hoodiehq/hoodie-app-tracker that referenced this issue Feb 27, 2016
@gr2m
fix: /hoodie/bundle.js is now /hoodie/client.js
15607df 
hoodiehq/discussion#89
gr2m added a commit to hoodiehq/hoodie-app-tracker that referenced this issue Feb 27, 2016
@gr2m
fix: /hoodie/bundle.js is now /hoodie/client.js
6ae2cf2 
hoodiehq/discussion#89
@gr2m gr2m mentioned this issue Mar 1, 2016
Open
gr2m added a commit to hoodiehq/hoodie-server that referenced this issue Mar 6, 2016
@gr2m
WIP - /hoodie/bundle.js is now /hoodie/client.js
8650d7c 
hoodiehq/discussion#89

* * *

This commit was sponsored by Neighbourhoodie

You can hire Neighbourhoodie for all your
Hoodie / CouchDB / Offline First needs
http://go.hood.ie/thehoodiefirm
gr2m added a commit to hoodiehq/hoodie-server that referenced this issue Apr 15, 2016
@gr2m
WIP - /hoodie/bundle.js is now /hoodie/client.js
7e9dc0f 
hoodiehq/discussion#89

* * *

This commit was sponsored by Neighbourhoodie

You can hire Neighbourhoodie for all your
Hoodie / CouchDB / Offline First needs
http://go.hood.ie/thehoodiefirm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gr2m @varjmes @boennemann @HipsterBrown