Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind null in object construction #83

Closed
ransomw opened this issue Mar 16, 2016 · 3 comments
Closed

bind null in object construction #83

ransomw opened this issue Mar 16, 2016 · 3 comments
Assignees
@acdpnk

Comments

@ransomw
Copy link
Contributor

ransomw commented Mar 16, 2016

follow up for #19 / #77

replace bind(this, with bind(null, per comments in admin/index.js.

also consider updating object construction elsewhere in the repository with the new pattern if discussion deems appropriate.
@ransomw ransomw mentioned this issue Mar 16, 2016
Merged
@acdpnk
Copy link
Contributor

acdpnk commented Mar 26, 2016

Hey @ransomw, mind if I do this?

@gr2m
Copy link
Member

gr2m commented Mar 26, 2016

first come first served, no need to ask :)

@acdpnk
Copy link
Contributor

acdpnk commented Mar 26, 2016

Okie dokie 😅

acdpnk added a commit to acdpnk/hoodie-client-account that referenced this issue Mar 26, 2016
@acdpnk
refactor(admin): bind null instead of this in constructor
e7e4885 
in AdminAccount constructor, `this` is bound but never used, instead the `state` variable is passed around. Therefore binding to `null` is cleaner and safer

hoodiehq#83
acdpnk added a commit to acdpnk/hoodie-client-account that referenced this issue Mar 26, 2016
@acdpnk
refactor(account): bind null instead of this in constructor
3b62f44 
In Account constructor, `this` is bound but never used, instead the `state` variable is passed around. Therefore binding to `null` is cleaner and safer

hoodiehq#83
@acdpnk acdpnk mentioned this issue Mar 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acdpnk acdpnk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gr2m @acdpnk @ransomw