feat: emit update event on profile change #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM ✨
|
|
looking at it now |
|
The account account.on('update', function (account) {
// account.profile is undefined
})
account.profile.update({foo: 'bar'})It’s somewhat related to #107. Probably the simplest solution for both #107 and this PR is to always include profile everywhere. It might eventually become a performance issues with people start storing gazillions of data in account profiles, but until then we should be fine? Any thoughts? |
|
never mind, this is not affected, profile is included in the update event, LGTM! Merging |
gr2m
force-pushed
the
profile-update-event
branch
from
6f9130b
to
a3eb4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.