drop localStorage usage #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2016
Merged
Merged
BREAKING CHANGE: The `pre:*` and `post:*` events introduced in #65 have now been removed in favor of a proper `account.hook.{before,after}` API. See https://github.com/hoodiehq/hoodie-account-client#hooks for more details. This is not technically a breaking change as the `pre:*` and `post:*` events have not been documented, but as they are used by `@hoodie/client` we decided to make this a breaking change nevertheless
BREAKING CHANGE:
As part of our effort to make Hoodie Client compatible with Service Worker and other environments that do not have access to localStorage, we have to make the Account Client compatible with async store APIs. That means we can’t load the current account state synchronously, so this is no longer be possible:
```js
var account = new Account({
url: /api
})
if (account.isSignedIn()) {
sayHi(account.username)
}
```
Starting with this release, you have to wrap the synchronous methods and properties into `account.ready.then()`
```js
account.ready.then(function () {
if (account.isSignedIn()) {
sayHi(account.username)
}
})
```
By default, the account will still use localStorage (via [humble-localstorage](https://github.com/gr2m/humble-localstorage)) to persist its state, but it will now be made asynchronous. In order to use another storage a new `options.cache` argument can be passed to the Account constructor:
```js
var account = new Account({
url: /api,
cache: {
set: writeAccountState
get: getAccountState,
unset: clearAccountState,
}
})
```
All three `options.cache` methods must return promises. `options.cache.get` must resolve with the persisted account properties or an empty object.
|
I got this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of hoodiehq/camp#101