cross-module initialisations #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
with the latest commit: ebc304e this should be good to go. Now needs tests |
2 tasks
|
This is good for review @hoodiehq/maintainers. Together with hoodiehq/hoodie-store-client#97, this will fix several crucial issue the Hoodie Tent Version has today. Ignore the decrease in coveralls, we don’t have 100% code coverage anyway at this point. |
|
Makes sense to me. The variable names are great and very clear. I'm really enjoying the use of |
|
thanks for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3
there are several things that need to be initialised in Hoodie’s client constructor, where we combine account, store etc APIs. They are all listed here: #3.