test(init.js): to reach 100% code coverage. #85
Conversation
|
Wow, that is spot on! Thanks for the great work! Is this your first PR to an open source project? LGTM. PIng @hoodiehq/maintainers |
|
yes - and i realized that there are some spelling mistakes .... |
| on: simple.stub(), | ||
| isSignedIn: simple.stub().returnWith(false) | ||
| }, | ||
| store: simple.stub(), |
There was a problem hiding this comment.
the method we want to stub here is not hoodie.store() but hoodie.store.connect(). Sorry I missed this before, could you please change it?
In the PR? Then best to fix them right away. If you found typos in other places it’d be best start separate pull requests |
mccullagh
force-pushed
the
feature/new_init_tests
branch
2 times, most recently
from
c4e5d40
to
ccb3bdd
Compare
mccullagh
force-pushed
the
feature/new_init_tests
branch
from
ccb3bdd
to
cda00df
Compare
|
Do i need to do something? |
|
@mccullagh no you are all good, thanks. Usually we need two people from the maintainers team to comment with "LGTM", only then then But as many of our maintainers are currently conferencing through Europe and this PR doesn’t touch actual code, I’ll take advantage of my admin rights and will just merge it in :) Thanks for the great work! |
closes #79