fix: don't modify the passed options object

[rmehner]

So in this project we're registering multiple servers as to Hapi, kinda like this:

var options = {
  db: {
    url: process.env.COUCH_URL
  }
}

server.register([
  { register: hoodie, options: options },
  { register: otherEndpoint, options: options }
], function (error) {})

the problem is, due to hoodie server's behaviour here, otherEndpoint never sees what's in options.db and will always have an empty object.

This PR fixes this behaviour by cloning the options object before doing anything on it.

[gr2m]

LGTM, thanks Robin!
ping @hoodiehq/maintainers

[janl]

didn’t we decide on full loadash on the server instead of single functions?

No blocker tho

[rmehner]

didn’t we decide on full loadash on the server instead of single functions?

I've adapted from here:

hoodie/cli/options.js

Line 3 in 7a98915

var pick = require('lodash').pick

But yeah, found out about the CODING_STYLE.md now, will create another PR that fixes this inside of server/index.js.

[gr2m]

this is the full lodash. the alternative would have been be require('lodash/cloneDeep')

[janl]

LGTM