feat: Default url option to location.origin in bundle #648
Conversation
| @@ -65,9 +65,19 @@ function buildBundle (config, hoodieClientPath, callback) { | |||
| return callback(error) | |||
| } | |||
|
|
|||
| var options = config.url ? '{url: "' + config.url + '"}' : '' | |||
| var initBuffer = Buffer('\n\nhoodie = new Hoodie(' + options + ')') | |||
| var initScript = '\n\n' | |||
There was a problem hiding this comment.
this won’t hurt, but am curious: why not just var initScript = ''?
There was a problem hiding this comment.
Only to have some space between the client and initialization code. It also was the same way before :)
|
@sdvg Hoodie Client v6 is released, can you please update the |
|
@gr2m Isn't it already in master? https://github.com/hoodiehq/hoodie/blob/master/package.json#L16 |
|
ooops yes, sorry, we have to wait for v7, currently waiting for travis https://travis-ci.org/hoodiehq/hoodie-client/builds/181153131 |
|
okay it’s out now :) https://github.com/hoodiehq/hoodie-client/releases/tag/v7.0.0 |
| @@ -13,7 +13,7 @@ | |||
| "dependencies": { | |||
| "@hoodie/account": "^2.0.0", | |||
| "@hoodie/admin": "^1.0.1", | |||
| "@hoodie/client": "^6.0.0", | |||
| "@hoodie/client": "^7.0.0", | |||
There was a problem hiding this comment.
when we update "dependencies", we use the fix: prefix to force a new release, this helps to deduplicate (sub) dependencies. Only for "devDependencies" we use the chore: prefix because they don’t get installed by modules that depend on it.
But for this PR it makes no difference as we already have the feat: prefix, so I’m going ahead and merge it as is :)
There was a problem hiding this comment.
Thanks, will do so next time :)
gr2m
force-pushed
the
105-bundle-default-url
branch
from
9436267
to
2cd59db
Compare
Closes hoodiehq/hoodie-client#105. Closes #649
This belongs to hoodiehq/hoodie-client#109. The issue required changes in both repositories.