Fix client plugins crashing hoodie server in Windows #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Windows adding a client plugin as described in http://docs.hood.ie/en/latest/guides/plugins.html will crash hoodie server with error Error: Cannot find module 'C:UsersUserdevhoodie-serverhoodieclient' as backslashes in Windows paths are collapsed when building the string hoodieBundleSource. The fix replaces backslashes in the paths with forward slashes which work both in Linux and Windows.
|
Thanks David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, adding a client plugin as described in
http://docs.hood.ie/en/latest/guides/plugins.htmlwill crash hoodie server with error:as backslashes in Windows paths are collapsed when building the string
hoodieBundleSource.The fix replaces backslashes in the client plugins paths with forward slashes, which work both in Linux and Windows.