Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to eval-like DOM function #868

Merged
merged 1 commit into from Apr 18, 2019
Merged

Call to eval-like DOM function #868

merged 1 commit into from Apr 18, 2019

Conversation

matbrgz
Copy link
Contributor

@matbrgz matbrgz commented Apr 18, 2019

DOM functions that act like 'eval' and execute strings as code are dangerous and impede program analysis and understanding. Consequently, they should not be used.

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough :) thanks!

@gr2m gr2m merged commit 8e29eb5 into hoodiehq:master Apr 18, 2019
@matbrgz matbrgz deleted the patch-1 branch April 18, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants