Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portability #872 #873

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Portability #872 #873

merged 5 commits into from
Jul 10, 2019

Conversation

md37
Copy link
Contributor

@md37 md37 commented Jul 10, 2019 •
edited
Loading

I fixed #872 npm start for Windows by adding portable script.js in package.json.

jtdorseyiii
jtdorseyiii approved these changes Jul 10, 2019
View reviewed changes
Copy link

@jtdorseyiii jtdorseyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo! I can now clone hoodie, install and start it with these changes!

Terreii
Terreii reviewed Jul 10, 2019
View reviewed changes
start.js Outdated Show resolved Hide resolved
md37 and others added 2 commits July 10, 2019 16:40
@md37 @Terreii
Update start.js
739cd47 
Co-Authored-By: Christopher <christopher.astfalk@icloud.com>
@md37
Update start.js
6553346 
Removed duplicate code
@md37 md37 closed this Jul 10, 2019
@md37 md37 reopened this Jul 10, 2019
gr2m
gr2m approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@gr2m gr2m merged commit 3b76427 into hoodiehq:master Jul 10, 2019
@md37 md37 deleted the portability branch July 12, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Terreii Terreii Terreii left review comments

@gr2m gr2m gr2m approved these changes

@jtdorseyiii jtdorseyiii jtdorseyiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm start command fails
4 participants
@md37 @gr2m @jtdorseyiii @Terreii