Complete code coverage #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrwhite
force-pushed
the
complete-code-coverage
branch
from
3060fb3
to
0d763aa
Compare
gr2m
requested changes
Nov 10, 2016
| }) | ||
| }) | ||
| .then(function (userEntry) { | ||
| preinitializedAdmins = db.admins({secret: 'secretXYZ', admins: {'foo': userEntry}}) |
There was a problem hiding this comment.
do we need to dynamically generate userEntry here or can we directly use a pre-generated key?
There was a problem hiding this comment.
If we need to run generateSalt or hashPassword for code coverage, I鈥檇 rather make unit tests
There was a problem hiding this comment.
Yeah, no need to run generateSalt or hashPassword, it was just for convenience rather than hardcoding in a pre-generated key at the time; but it probably makes sense to pregenerate it. Changing now.
|
close! Love it 馃挴馃槏 |
Insert pregenerated admin key rather than generating in-test
gr2m
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push code coverage up to 馃挴