Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.findAll() should not return design docs #46

Closed
gr2m opened this issue Jul 11, 2015 · 6 comments
Closed

.findAll() should not return design docs #46

gr2m opened this issue Jul 11, 2015 · 6 comments

Comments

@gr2m
Copy link
Member

gr2m commented Jul 11, 2015

it's a store API, meant only to interact with objects stored in it. CouchDB design docs is an implementation detail that we should not expose.

So by default, I'd vote that at least the *All methods like findAll should ignore design docs.

Any thoughts?

@zoepage
Copy link
Contributor

zoepage commented Jul 13, 2015

+1

@janl
Copy link
Member

janl commented Jul 16, 2015

do they take options, so people can opt into getting ddocs?

@gr2m
Copy link
Member Author

gr2m commented Jul 16, 2015

If people want ddocs, they can still use the PouchDB instance that we expose at store.db. I think the API is just fine: store.db.get(ddocid)

@janl
Copy link
Member

janl commented Jul 17, 2015

perfect.

@NickColley
Copy link
Contributor

I'm going to have a go fixing this bug fyi 🐧

@gr2m
Copy link
Member Author

gr2m commented Aug 20, 2015

fixed via #60

@gr2m gr2m closed this as completed Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants