Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added digest to hash-password #10

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
3 participants
@Terreii
Copy link
Contributor

commented Apr 7, 2017

On node.js version 6 the digest on crypto.pbkdf2 is required.
Default is 'sha1‘.

Added digest to hash-password
On node.js version 6 the digest on crypto.pbkdf2 is required.
Default is 'sha1‘.

@janl janl merged commit 5c6b484 into hoodiehq:master Apr 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markwatsonatx

This comment has been minimized.

Copy link

commented Jun 2, 2017

This fix is required for Node.js 8. In Node.js 6 and 7 the following warning was printed:

(node:35) DeprecationWarning: crypto.pbkdf2 without specifying a digest is deprecated. Please specify a digest

In Node.js 8 the function has been removed and results in an unhandled exception in Hoodie.

Changing this file manually in node_modules fixes the issue. I believe the only thing that is required is to release a new version of this module on npm with this change that has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.