Added digest to hash-password #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On node.js version 6 the digest on crypto.pbkdf2 is required. Default is 'sha1‘.
|
This fix is required for Node.js 8. In Node.js 6 and 7 the following warning was printed:
In Node.js 8 the function has been removed and results in an unhandled exception in Hoodie. Changing this file manually in node_modules fixes the issue. I believe the only thing that is required is to release a new version of this module on npm with this change that has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On node.js version 6 the digest on crypto.pbkdf2 is required.
Default is 'sha1‘.