fix: Lint issues

hookdeck · Sep 15, 2023 · 403231e · 403231e
1 parent cd612eb
commit 403231e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/internal/provider/connection/sdk.go b/internal/provider/connection/sdk.go
@@ -111,7 +111,9 @@ func transformFilterRuleProperty(property *filterRuleProperty) *hookdeck.FilterR
 		// parse string to JSON
 		var jsonData map[string]any
 		jsonBytes := []byte(property.JSON.ValueString())
-		json.Unmarshal(jsonBytes, &jsonData)
+		if err := json.Unmarshal(jsonBytes, &jsonData); err != nil {
+			return nil
+		}
 		return hookdeck.NewFilterRulePropertyFromStringUnknownMapOptional(jsonData)
 	}
 	if !property.Number.IsUnknown() && !property.Number.IsNull() {

diff --git a/internal/provider/destination/sdk.go b/internal/provider/destination/sdk.go
@@ -63,7 +63,7 @@ func (m *destinationResourceModel) ToCreatePayload() *hookdeck.DestinationCreate
 	} else {
 		httpMethod = nil
 	}
-	var pathForwardingDisabled *hookdeckcore.Optional[bool] = nil
+	var pathForwardingDisabled *hookdeckcore.Optional[bool]
 	if !m.PathForwardingDisabled.IsUnknown() && !m.PathForwardingDisabled.IsNull() {
 		pathForwardingDisabled = hookdeck.Optional(m.PathForwardingDisabled.ValueBool())
 	} else {
@@ -224,7 +224,7 @@ func (m *destinationResourceModel) refreshAuthMethod(destination *hookdeck.Desti
 	if destination.AuthMethod.CustomSignature != nil {
 		m.AuthMethod.CustomSignature = &customSignature{}
 		m.AuthMethod.CustomSignature.Key = types.StringValue(destination.AuthMethod.CustomSignature.Config.Key)
-		m.AuthMethod.CustomSignature.SigningSecret = types.StringValue(string(*destination.AuthMethod.CustomSignature.Config.SigningSecret))
+		m.AuthMethod.CustomSignature.SigningSecret = types.StringValue(*destination.AuthMethod.CustomSignature.Config.SigningSecret)
 	}
 
 	if destination.AuthMethod.HookdeckSignature != nil {

diff --git a/internal/provider/sourceverification/sdk.go b/internal/provider/sourceverification/sdk.go
@@ -12,7 +12,7 @@ func (m *sourceVerificationResourceModel) ToCreatePayload() *hookdeck.SourceUpda
 }
 
 func (m *sourceVerificationResourceModel) ToUpdatePayload() *hookdeck.SourceUpdateRequest {
-	var verification *hookdeck.VerificationConfig = nil
+	var verification *hookdeck.VerificationConfig
 
 	// generic
 	if m.Verification.APIKey != nil {

diff --git a/internal/provider/transformation/sdk.go b/internal/provider/transformation/sdk.go
@@ -51,7 +51,9 @@ func (m *transformationResourceModel) getENV() map[string]string {
 	var envData map[string]string = nil
 	if !m.ENV.IsUnknown() && !m.ENV.IsNull() {
 		envBytes := []byte(m.ENV.ValueString())
-		json.Unmarshal(envBytes, &envData)
+		if err := json.Unmarshal(envBytes, &envData); err != nil {
+			return nil
+		}
 	}
 	return envData
 }