Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:basic auth user -> username attribute change #61

Merged
merged 5 commits into from
May 10, 2024

Conversation

leggetter
Copy link
Collaborator

Fixes:

hookdeck_source_verification.my_authenticated_source: Creating...
╷
│ Error: Value Conversion Error
│ 
│   with hookdeck_source_verification.my_authenticated_source,
│   on main.tf line 26, in resource "hookdeck_source_verification" "my_authenticated_source":
│   26: resource "hookdeck_source_verification" "my_authenticated_source" {
│ 
│ An unexpected error was encountered trying to convert tftypes.Value into sourceverification.basicAuthSourceVerification. This is always an error in the provider. Please report the following to the provider developer:
│ 
│ mismatch between struct and object: Struct defines fields not found in object: username. Object defines fields not found in struct: name.

@leggetter
Copy link
Collaborator Author

@alexluong tested locally:

Terraform will perform the following actions:

  # hookdeck_source_verification.my_authenticated_source will be created
  + resource "hookdeck_source_verification" "my_authenticated_source" {
      + source_id    = "src_vzc72yltwkkrw2"
      + verification = {
          + basic_auth = {
              + password = (sensitive value)
              + username = "example-username"
            }
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

hookdeck_source_verification.my_authenticated_source: Creating...
hookdeck_source_verification.my_authenticated_source: Creation complete after 0s

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

@leggetter leggetter requested a review from alexluong May 10, 2024 15:24
Comment on lines 13 to 16
"username": schema.StringAttribute{
Required: true,
},
"password": schema.StringAttribute{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick here, usually I organize schema attributes alphabetically. Not a big deal but just sharing that's how I've been doing it.

@leggetter leggetter merged commit 5de0b5c into main May 10, 2024
14 checks passed
@leggetter leggetter deleted the fix/basic-auth-username-attr branch May 10, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants