perf: distribute via webpack bundling (#22)

* perf: distribute via webpack bundling

* chore: should fix codeclimate errors

.azure-pipelines-steps.yml

@@ -27,6 +27,11 @@ steps:
     displayName: "Check linting"
     condition: succeededOrFailed()
 
+  # Check types
+  - script: yarn lint:types
+    displayName: "Check types"
+    condition: succeededOrFailed()
+
   # Run test:ci
   - script: yarn test:ci
     displayName: "Run tests"

.codeclimate.yml

@@ -1,28 +1,30 @@
 version: "2"
-plugins:
-  eslint:
-    enabled: true
 
 exclude_patterns:
-  - "test/"
-  - "src/**/*.spec.ts"
+  - .azure-pipelines-steps.yml
+  - .azure-pipelines.yml
   - ".circleci/"
-  - "bin/"
-  - "docs/"
-  - "patches/"
-  - "util/"
   - ".codeclimate.yml"
   - ".eslintrc.js"
   - ".gitignore"
   - ".npmignore"
   - ".prettierignore"
-  - "CHANGELOG.md"
-  - "README.md"
   - "aws-spot-price.code-workspace"
+  - "bin/"
+  - "CHANGELOG.md"
   - "commitlint.config.js"
+  - "docs/"
   - "package.json"
+  - "patches/"
+  - "README.md"
+  - "src/**/*.spec.ts"
+  - "test/"
   - "tsconfig.json"
+  - "util/"
   - "yarn.lock"
+  - sonar-project.properties
+  - sonar-project.properties
+  - webpack.config.js
 
 checks:
   file-lines:

.eslintrc.js

@@ -23,14 +23,15 @@ module.exports = {
   ],
   plugins: ['@typescript-eslint', 'prettier'],
   rules: {
-    'no-console': 0,
+    'import/no-extraneous-dependencies': 0,
     'import/prefer-default-export': 0,
+    'no-console': 0,
     'no-param-reassign': 0,
     'prettier/prettier': 'error',
   },
   overrides: [
     {
-      files: ['test/*.js'],
+      files: ['test/*.js', 'webpack.config.js'],
       rules: {
         '@typescript-eslint/explicit-function-return-type': 0,
         '@typescript-eslint/no-var-requires': 0,

.npmignore

@@ -13,8 +13,12 @@ coverage
 docs/
 junit.xml
 node_modules/
+patches/
 sonar-project.properties
 src/
+stats.json
 test/
 tsconfig*.json
-util/
+util/
+webpack.config.js
+yarn.lock

bin/aws-spot-price

@@ -1,2 +1,2 @@
 #!/usr/bin/env node
-require('../dist/cli.js');
+require('../dist/aws-spot-price.bundle');

package.json

@@ -28,12 +28,13 @@
     "postinstall": "patch-package",
     "clean": "rm -rf dist && rm -rf coverage",
     "build:ec2-types": "ts-node -T util/generate-ec2-types.ts",
-    "build": "tsc",
+    "build": "webpack",
     "changelog": "conventional-changelog -i CHANGELOG.md -s -p angular",
     "test": "jest --runInBand --verbose",
     "test:coverage": "yarn test --coverage",
     "test:ci": "yarn test:coverage --ci --reporters=jest-junit --coverageReporters lcov --coverageReporters cobertura",
     "lint": "eslint **/*.ts",
+    "lint:types": "tsc",
     "semantic-release": "semantic-release"
   },
   "config": {
@@ -93,14 +94,6 @@
   "publishConfig": {
     "tag": "next"
   },
-  "dependencies": {
-    "aws-sdk": "^2.544.0",
-    "ora": "^4.0.2",
-    "patch-package": "^6.2.0",
-    "prompts": "^2.2.1",
-    "table": "^5.4.6",
-    "yargs": "^14.2.0"
-  },
   "devDependencies": {
     "@commitlint/cli": "^8.2.0",
     "@semantic-release/changelog": "^3.0.4",
@@ -115,6 +108,7 @@
     "@types/yargs": "^13.0.3",
     "@typescript-eslint/eslint-plugin": "^2.3.0",
     "@typescript-eslint/parser": "^2.3.0",
+    "aws-sdk": "^2.544.0",
     "commitizen": "^4.0.3",
     "conventional-changelog-cli": "^2.0.25",
     "cz-conventional-changelog": "3.0.2",
@@ -131,11 +125,19 @@
     "jest-mock-console": "^1.0.0",
     "lodash": "^4.17.15",
     "nock": "^11.4.0",
+    "ora": "^4.0.2",
+    "patch-package": "^6.2.0",
     "postinstall-postinstall": "^2.0.0",
     "prettier": "^1.18.2",
+    "prompts": "^2.2.1",
     "semantic-release": "^15.13.27",
+    "table": "^5.4.6",
     "ts-jest": "^24.1.0",
+    "ts-loader": "^6.2.1",
     "ts-node": "^8.4.1",
-    "typescript": "^3.6.3"
+    "typescript": "^3.6.3",
+    "webpack": "^4.41.2",
+    "webpack-cli": "^3.3.9",
+    "yargs": "^14.2.0"
   }
 }

src/cli.spec.ts

@@ -160,7 +160,7 @@ describe('cli', () => {
   });
 
   describe('test by spawnSync', () => {
-    const cliJsPath = resolve(__dirname, '../dist/cli.js');
+    const cliJsPath = resolve(__dirname, '../dist/aws-spot-price.bundle.js');
     it('should stdout help screen', () => {
       const s = spawnSync('node', [cliJsPath, '--help'], { encoding: 'utf-8' });
       expect(s.stdout).toMatchSnapshot();

src/lib/credential.ts

@@ -1,4 +1,4 @@
-import { config, STS } from 'aws-sdk';
+import STS = require('aws-sdk/clients/sts');
 
 type AuthErrorCode = 'CredentialsNotFound' | 'UnAuthorized';
 
@@ -17,21 +17,20 @@ export const awsCredentialsCheck = async (options?: {
   secretAccessKey?: string;
 }): Promise<void> => {
   const { accessKeyId, secretAccessKey } = options || {};
-
+  const sts = new STS({
+    accessKeyId,
+    secretAccessKey,
+  });
   if (
     !accessKeyId &&
     !secretAccessKey &&
-    !config.credentials &&
+    !sts.config.credentials &&
     !(process.env.AWS_ACCESS_KEY_ID && process.env.AWS_SECRET_ACCESS_KEY)
   ) {
     throw new AuthError('AWS credentials unavailable.', 'CredentialsNotFound');
   }
 
   try {
-    const sts = new STS({
-      accessKeyId,
-      secretAccessKey,
-    });
     await sts.getCallerIdentity().promise();
   } catch (error) {
     throw new AuthError(error.message, 'UnAuthorized');

src/lib/lib.ts

@@ -1,4 +1,4 @@
-import { EC2 } from 'aws-sdk';
+import * as EC2 from 'aws-sdk/clients/ec2';
 import * as ora from 'ora';
 import { table } from 'table';
 

tsconfig.json

@@ -9,9 +9,7 @@
     "sourceMap": true,
     "downlevelIteration": true,
     "rootDir": "src",
-    "outDir": "dist",
-    "experimentalDecorators": true,
-    "emitDecoratorMetadata": true
+    "noEmit": true
   },
   "files": [
     "src/cli.ts",

util/generate-spot-prices-mock-data.ts

@@ -1,4 +1,4 @@
-import { EC2 } from 'aws-sdk';
+import * as EC2 from 'aws-sdk/clients/ec2';
 import { readFileSync, writeFileSync } from 'fs';
 import { find, uniqWith, xorWith } from 'lodash';
 import { resolve } from 'path';

webpack.config.js

@@ -0,0 +1,33 @@
+const path = require('path');
+
+module.exports = {
+  mode: 'production',
+  entry: path.resolve(__dirname, 'src/cli.ts'),
+  resolve: {
+    extensions: ['.js', '.json', '.ts'],
+  },
+  output: {
+    libraryTarget: 'commonjs',
+    path: path.join(__dirname, 'dist'),
+    filename: 'aws-spot-price.bundle.js',
+  },
+  stats: {
+    warningsFilter: [/node_modules\/yargs/],
+  },
+  target: 'node',
+  module: {
+    rules: [
+      {
+        test: /\.tsx?$/,
+        use: [
+          {
+            loader: 'ts-loader',
+            options: {
+              transpileOnly: true,
+            },
+          },
+        ],
+      },
+    ],
+  },
+};