Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move use cases to connections #36

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Mar 22, 2023

move use cases to connections

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for hoopdev ready!

Name Link
🔨 Latest commit 3c8b5f4
🔍 Latest deploy log https://app.netlify.com/sites/hoopdev/deploys/6474c8562c59b8000861fb50
😎 Deploy Preview https://deploy-preview-36--hoopdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krol3 krol3 requested review from rogefm and removed request for andriosrobert March 22, 2023 14:13
@krol3 krol3 force-pushed the move-usecase-to-connections branch 2 times, most recently from 7ce7b10 to 275c229 Compare March 22, 2023 15:34
@andriosrobert
Copy link
Contributor

run npm run build on your computer and you'll get the error, this is what the CI runs. lmk if it works or check readme for more info. will check Netlify access later

@krol3 krol3 force-pushed the move-usecase-to-connections branch from 275c229 to 106df01 Compare March 31, 2023 10:02
@krol3
Copy link
Contributor Author

krol3 commented Mar 31, 2023

@andriosrobert could you check the preview?

@andriosrobert
Copy link
Contributor

I like it, but I still see the use cases folder with one item. I would remove this menu and keep everything inside connections

other than that, I like this a lot!

@krol3
Copy link
Contributor Author

krol3 commented Apr 11, 2023

I like it, but I still see the use cases folder with one item. I would remove this menu and keep everything inside connections

other than that, I like this a lot!

I left this use case "scripts", for me, it could be our first use case, it contains video and explains a complete flow. https://hoop.dev/docs/usecases/scripts @andriosrobert

@krol3
Copy link
Contributor Author

krol3 commented Apr 11, 2023

I like it, but I still see the use cases folder with one item. I would remove this menu and keep everything inside connections

other than that, I like this a lot!

I left this in the use case, because for me, it could be our first use case, it contains video and explain a complete flow. https://hoop.dev/docs/usecases/scripts

krol3 added 3 commits May 29, 2023 11:17
Signed-off-by: carolina valencia <krol3@users.noreply.github.com>
Signed-off-by: carolina valencia <krol3@users.noreply.github.com>
@krol3 krol3 force-pushed the move-usecase-to-connections branch from b4b1b6d to a979e53 Compare May 29, 2023 14:42
---

import ConnectOnHoopButton from './../../src/components/ConnectOnHoopButton';

# Heroku one-off
# Heroku execute task one-off
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I would change the task to session here. I say that because task is a Runops concept and I would want to avoid confusion but maybe it's here for a reason that I don't know

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to heroku one off dynos:
https://devcenter.heroku.com/articles/one-off-dynos


The Elastic Container Service allows executing one off tasks of any type directly into ECS tasks/containers.
Interact with Elastic Container Service executing one off tasks or an interactive session into ECS tasks/containers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

---

import ConnectOnHoopButton from './../../src/components/ConnectOnHoopButton';

# Heroku | exec
# Heroku | interactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe interactive is the command "connect" not the "exec". I always make misunderstand these kinds of commands, hahaha, but I believe that "exec" is not interactive.
What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The psexec allows connecting both interactive and non-interactive as do heroku one-off. The difference between then is that ps-exec executes stuff inside a running dyno and the other one executes in an one off dyno:
https://devcenter.heroku.com/articles/one-off-dynos

hoop connect my-ecs -- --pipe clojure
```

## AWS ECS - Execute one task off
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task to session here as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to call "One Off Execution" @mtmr0x . The session is derived from an execution.

@rogefm
Copy link
Contributor

rogefm commented May 29, 2023

Also, we already have "Postgres" native and I believe we have "MySQL" as well, but I would ask Sandro before implementing it.

@rogefm
Copy link
Contributor

rogefm commented May 29, 2023

Screenshot 2023-05-29 at 12 31 52

I believe this one is lost in this connection session. Is this from "user guides"?

@sandromello
Copy link
Contributor

Also, we already have "Postgres" native and I believe we have "MySQL" as well, but I would ask Sandro before implementing it.

It's already documented: https://deploy-preview-36--hoopdev.netlify.app/docs/connections/mysql

@krol3
Copy link
Contributor Author

krol3 commented May 29, 2023

@mtmr0x ,I open an issue to map this old runops "terminology" and discuss the new terms. #54

I will open another PR to adjust the updated terms. This PR is to move use-cases to connections.

Signed-off-by: carolina valencia <krol3@users.noreply.github.com>
@krol3 krol3 force-pushed the move-usecase-to-connections branch from 0d8d66c to 3c8b5f4 Compare May 29, 2023 15:44
@krol3 krol3 requested a review from mtmr0x May 31, 2023 13:21
@andriosrobert
Copy link
Contributor

lgtm

@krol3 krol3 merged commit 307002b into main Jun 9, 2023
5 checks passed
@krol3 krol3 deleted the move-usecase-to-connections branch June 9, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants