Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendship always accepted #12

Closed
smokills opened this issue Feb 26, 2016 · 9 comments
Closed

Friendship always accepted #12

smokills opened this issue Feb 26, 2016 · 9 comments

Comments

@smokills
Copy link

When I send a friendship request to a model, when I check if a model is friend with another (using $user->isFriendWith($recipient), it will return me always true, even if the request is still pending.

@RosiersRobin
Copy link

Got the same issue here.

@hootlex
Copy link
Owner

hootlex commented Feb 26, 2016

That's weird. Which version do you use guys?

The tests show that it is working correctly on v1.0.9

@hootlex
Copy link
Owner

hootlex commented Mar 3, 2016

@Advil-Robin @VitoFamiglietti is this still an issue?

@smokills
Copy link
Author

smokills commented Mar 3, 2016

Yes, when I dd it still returns me true even if the friendship is still
pending
Il giorno gio 3 mar 2016 alle 04:32 Alex Kyriakidis <
notifications@github.com> ha scritto:

@Advil-Robin https://github.com/Advil-Robin @VitoFamiglietti
https://github.com/VitoFamiglietti is this still an issue?


Reply to this email directly or view it on GitHub
#12 (comment)
.

@hootlex
Copy link
Owner

hootlex commented Mar 3, 2016

Which version of the package do you use?
Στις 3 Μαρ 2016 19:09, ο χρήστης "Vito" notifications@github.com έγραψε:

Yes, when I dd it still returns me true even if the friendship is still
pending
Il giorno gio 3 mar 2016 alle 04:32 Alex Kyriakidis <
notifications@github.com> ha scritto:

@Advil-Robin https://github.com/Advil-Robin @VitoFamiglietti
https://github.com/VitoFamiglietti is this still an issue?


Reply to this email directly or view it on GitHub
<
#12 (comment)

.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@smokills
Copy link
Author

smokills commented Mar 3, 2016

the dev version. i guess the 1.9

Il giorno gio 3 mar 2016 alle ore 19:14 Alex Kyriakidis <
notifications@github.com> ha scritto:

Which version of the package do you use?
Στις 3 Μαρ 2016 19:09, ο χρήστης "Vito" notifications@github.com έγραψε:

Yes, when I dd it still returns me true even if the friendship is still
pending
Il giorno gio 3 mar 2016 alle 04:32 Alex Kyriakidis <
notifications@github.com> ha scritto:

@Advil-Robin https://github.com/Advil-Robin @VitoFamiglietti
https://github.com/VitoFamiglietti is this still an issue?


Reply to this email directly or view it on GitHub
<

#12 (comment)

.


Reply to this email directly or view it on GitHub
<
#12 (comment)

.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@hootlex
Copy link
Owner

hootlex commented Mar 3, 2016

Have you tried to update the package?
Στις 3 Μαρ 2016 20:16, ο χρήστης "Vito" notifications@github.com έγραψε:

the dev version. i guess the 1.9

Il giorno gio 3 mar 2016 alle ore 19:14 Alex Kyriakidis <
notifications@github.com> ha scritto:

Which version of the package do you use?
Στις 3 Μαρ 2016 19:09, ο χρήστης "Vito" notifications@github.com
έγραψε:

Yes, when I dd it still returns me true even if the friendship is still
pending
Il giorno gio 3 mar 2016 alle 04:32 Alex Kyriakidis <
notifications@github.com> ha scritto:

@Advil-Robin https://github.com/Advil-Robin @VitoFamiglietti
https://github.com/VitoFamiglietti is this still an issue?


Reply to this email directly or view it on GitHub
<

#12 (comment)

.


Reply to this email directly or view it on GitHub
<

#12 (comment)

.


Reply to this email directly or view it on GitHub
<
#12 (comment)

.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@smokills
Copy link
Author

smokills commented Mar 4, 2016

Yes, and it seems works now. Thanks :)

Il giorno gio 3 mar 2016 alle ore 19:19 Alex Kyriakidis <
notifications@github.com> ha scritto:

Have you tried to update the package?
Στις 3 Μαρ 2016 20:16, ο χρήστης "Vito" notifications@github.com έγραψε:

the dev version. i guess the 1.9

Il giorno gio 3 mar 2016 alle ore 19:14 Alex Kyriakidis <
notifications@github.com> ha scritto:

Which version of the package do you use?
Στις 3 Μαρ 2016 19:09, ο χρήστης "Vito" notifications@github.com
έγραψε:

Yes, when I dd it still returns me true even if the friendship is
still
pending
Il giorno gio 3 mar 2016 alle 04:32 Alex Kyriakidis <
notifications@github.com> ha scritto:

@Advil-Robin https://github.com/Advil-Robin @VitoFamiglietti
https://github.com/VitoFamiglietti is this still an issue?


Reply to this email directly or view it on GitHub
<

#12 (comment)

.


Reply to this email directly or view it on GitHub
<

#12 (comment)

.


Reply to this email directly or view it on GitHub
<

#12 (comment)

.


Reply to this email directly or view it on GitHub
<
#12 (comment)

.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@hootlex
Copy link
Owner

hootlex commented Mar 4, 2016

Good :)

@hootlex hootlex closed this as completed Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants