Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

Implement drag and drop behaviour that is more section-friendly #23

Closed
4 tasks
aismail opened this issue Apr 1, 2014 · 0 comments
Closed
4 tasks

Implement drag and drop behaviour that is more section-friendly #23

aismail opened this issue Apr 1, 2014 · 0 comments

Comments

@aismail
Copy link
Contributor

aismail commented Apr 1, 2014

Need

As an user
I want drag in the context of sections with delimiters between them to favour widgets to remain in the same section
So that I have a sense of grouping for the widgets

PS - for the issue about adding delimiters, see #14

Deliverables

  • test-cases for the new situations (see fixtures.js)
  • pull to left behaviour should stop at section boundary (similar to how timelines work)
  • collision detection should try harder to solve collisions within the same section (maybe generate more positions that are adjacent to the colliding widget instead of just 4 of them?)
  • users should not be able to place a widget that spans 2 sections on the grid:
    • dragging should snap the widget to one section
    • resizing should make sure the widget ends up only on one section
    • layout algorithm should only place widgets within sections
@aismail aismail self-assigned this Apr 1, 2014
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Added fixtures for new set of specs.
f49f491
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Correctly mark collisions as resolved if there were no collisions
a51c399
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Added new columnsPerGroup option
1a89683 
CC @skidding
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Finding positions is now aware of the concept of sections
02c3b59
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Snapping to grid is now aware of the concept of sections
ae54a30
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Making itemSpansMoreThanOneSection public method
70e1105
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Revamping first scenario (now dragging 10 to the right; added ids)
653b1a1
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Add matcher that does not depend on item order, but on their ids.
c72dd21
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Add test for dragging item 10 to the right
3087ff3
aismail pushed a commit that referenced this issue Apr 1, 2014
#23 Second pullToLeft should only be done in non-sections mode.
37e64b7
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Add API for moving all sections to the right, starting with a spe…
2353a2b 
…cified one

Optionally, it can skip an item that is already within the range of
sections. The use-case for that is dropping an item onto a section, and
the local collisions not being resolved.
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 _findLeftMostPositionForItem now stops at page boundary whenever …
e231e39 
…column sections are enabled
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Refactor code in pullToLeft that places items starting with their…
49aefcb 
… leftmost limit.
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Collision resolving works differently in column sections mode
6aa9629 
It tries to resolve the collisions locally and then pushes all the
content to the right by preserving section integrity.
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 In column sections mode, collision detection only tries candidate…
466e245 
…s within the same section
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 API for getting the section number of an item
46ab62d
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Added API for retrieving an item given multiple attributes.
202c846
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Resizing an item pushes it to the next section if it cannot fit i…
3ec7281 
…n the current section anymore.
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Deleting empty sections after resolving collisions in column sect…
3dfa80d 
…ion mode.
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Update fixtures with newer ones that also include item id.
6fbcf8d
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Add new testcases for column sections functionality
5a4e1e8
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Add failing test for dragging 7 on a new section and 10 over 7
558d810
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Forgot to commit fixture line
aca94d7
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 MEGA HACK TO BE REVERTED
71d6be8
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Merged with master.
5c0469d
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Replacing lib paths with src
956d821
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Reverting to original demo JS, customizing in order to test secti…
ae2c58e 
…ons concept
@ovidiuch ovidiuch mentioned this issue Apr 2, 2014
Closed
11 tasks
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Computing column positions each time we need them
c475395
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Move _resolveCollisions to the end of the file where we keep priv…
2c0f0c5 
…ate functions
aismail pushed a commit that referenced this issue Apr 2, 2014
#23 Refactoring code and adding more docs to the new methods.
da29535
valentinzberea added a commit that referenced this issue Apr 2, 2014
@valentinzberea
Make sure an item fits in current section #23
4f342da
valentinzberea added a commit that referenced this issue Apr 2, 2014
@valentinzberea
Make sure an item fits in current section #23
e75f677
@aismail aismail removed their assignment Apr 2, 2014
valentinzberea added a commit that referenced this issue Apr 3, 2014
@valentinzberea
Use itemSpansMoreThanOneSection method in detecting collisions #23
b7eedee
valentinzberea added a commit that referenced this issue Apr 3, 2014
@valentinzberea
Refactoring itemSpansMoreThanOneSection use #23
67820f1
valentinzberea added a commit that referenced this issue Apr 3, 2014
@valentinzberea
Add failing test for resize item_7 scenario #23
c83ece5
valentinzberea added a commit that referenced this issue Apr 3, 2014
@valentinzberea
Pull to left before resizing an item #23
f4a5960
valentinzberea added a commit that referenced this issue Apr 3, 2014
@valentinzberea
Don't pull left an item that is resized #23
6051075
@ovidiuch ovidiuch closed this as completed Apr 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aismail @ovidiuch