Gracefully handle empty or missing profiles #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scullingworth
requested review from
simba11,
neil-power-hs and
jody-chambers-hs
neil-power-hs
suggested changes
Apr 17, 2018
assets/modal.js
Outdated
| @@ -12,30 +12,34 @@ function populateMessage(data) { | |||
| appendTextToClass('hs_jsonDump', prettyJSONData); | |||
|
|
|||
| // finds network-specific information | |||
| var avatarURL = 'https://hootsuite.com/dist/images/logos/hootsuite/owly.png'; | |||
| var displayName = 'Hootsuite'; | |||
| var avatarURL = 'https://d12qyuqyvqjkw5.cloudfront.net/v2/images/dashboard/avatars/member-default-100.d3442c37.svg'; | |||
There was a problem hiding this comment.
I think that you can use the friendly url for this resource, I can't recall what it is at the moment but I will try to look it up.
There was a problem hiding this comment.
nice, thanks!
There was a problem hiding this comment.
You can use this url instead: http://static.hootsuite.com/v2/images/dashboard/avatars/member-default-100.d3442c37.svg
static.hootsuite.com maps to that cloudfront url.
| profileURL = 'https://www.youtube.com/channel/' + data.profile.userid; | ||
| break; | ||
| if (typeof data.profile === "undefined") { | ||
| // skip if profile is empty |
There was a problem hiding this comment.
Do we want to have an explanation why this profile would be empty. If an external (or internal) dev sees this, they won't know why it's being skipped and not supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.