This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Support for Ctypes , HTML and XML responses #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gbmor since I don't know anyone else to ask out for a review. It would be great if you could review this if you've got time. |
gbmor
reviewed
Feb 12, 2020
gbmor
reviewed
Feb 12, 2020
gbmor
reviewed
Feb 12, 2020
Closed
Co-Authored-By: Ben Morrison <ben@gbmor.dev>
Co-Authored-By: Ben Morrison <ben@gbmor.dev>
|
Thanks for the Review and Feedback @gbmor . I'll add you to the repository and I'm merging this |
|
Any time! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #6 and will make it easier to add the
-c/--ctypesflag with abbreviations likehtml:text/htmljs:application/json,xml:application/xmlplain:text/plainMaking it easier to input the whole Request with Content Types