Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is broken with old history in localStorage #74

Closed
nickpalenchar opened this issue Aug 28, 2019 · 5 comments
Closed

App is broken with old history in localStorage #74

nickpalenchar opened this issue Aug 28, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@nickpalenchar
Copy link
Contributor

nickpalenchar commented Aug 28, 2019

Describe the bug
Starting after 271bd06 (or perhaps around then), old localStorage from a user agent causes the app to break when navigating to the app.

To Reproduce
Steps to reproduce the behavior:

  1. Open the browser and open devTools
  2. Go to the tab for storage, click on localstorage
  3. Edit the history section to be [{"time":"2:57:54 PM","method":"POST","url":"https://reqres.in","path":"/api/users"},{"time":"2:56:30 PM","method":"GET","url":"https://reqres.in","path":"/api/users"},{"time":"10:33:28 AM","method":"GET","url":"https://reqres.in","path":"/api/users"}]
  4. Go to the postwoman page to get the app to break

Expected behavior
The app should fully load, any old history that can't be deciphered should be displayed with as much information as possible.

Desktop (please complete the following information):

  • OS: Mac OS Sierra
  • Browser: Firefox
  • Version 68.0 (64-bit)
@nickpalenchar
Copy link
Contributor Author

FYI I have a working solution that I am preparing 😎

@liyasthomas
Copy link
Member

I suspect this is the reason for few other issues that have reported and solved on flushing cache and local storage 🤔

Btw, these kinda people (@nickpalenchar) are 💎

@nickpalenchar
Copy link
Contributor Author

Agreed it's most likely the cause of other people's issues re: clearing cache/storage. What's nice is this bug points out a clear area to tackle when thinking about tests re #65.

It would be awesome to have some sort of regression tests, but quick(er) win would probably be to start in an e2e testing--something that would verify there are only expected properties (adding new ones would be fine, but the contributor would then have to acknowledge the change by updating the tests.). But that's a discussion for another feature

liyasthomas added a commit that referenced this issue Aug 28, 2019
fixes #74 fallback for findEntryStatus when match is missing or other…
@liyasthomas
Copy link
Member

@all-contributors please add @nickpalenchar for code

@allcontributors
Copy link
Contributor

@liyasthomas

We had trouble processing your request. Please try again later.

AndrewBastin pushed a commit that referenced this issue Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants