Fix intersection button send #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @guastallaigor, TravisBuddy Request Identifier: 96e56cf0-cb24-11e9-81b8-6fab94e294e1 |
|
@guastallaigor Your changes look a better way to to implement the feature. But i couldn't get it worked on the firefox. That should be the problem. I was working on firefox when i was implenting it and it was working fine. I suppose we should find the way for it to work in both in your environment and my environment. But for now your way looks better and also works in chrome. So i'll merge in yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion something is wrong right now with the button fixed, using the Intersection API (ref #107 #94). At my environment, it only works on the first scroll and every two full page scrolls after that.
This PR changes the logic a bit to make it work all the time.
Right now:
After this PR: