Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): fixed french translations #1815

Merged
merged 1 commit into from
Sep 6, 2021
Merged

chore(i18n): fixed french translations #1815

merged 1 commit into from
Sep 6, 2021

Conversation

bokub
Copy link
Contributor

@bokub bokub commented Sep 6, 2021

I tried hopscotch in french and found out the translations were really bad 😄

I fixed the most obvious ones, but I didn't have time to go deeper. I'm sure there are still a lot of errors that didn't catch my attention, but these files are loooong!

I might open another PR in a few days, but maybe not, depends if I find some free time.

P.S: I'm french.

@netlify
Copy link

netlify bot commented Sep 6, 2021

‼️ Deploy request for hoppscotch rejected.
Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: 9acdca1

@bokub bokub changed the title chore: french i18n translations chore(i18n): fixed french translations Sep 6, 2021
@liyasthomas
Copy link
Member

Thanks for the effort and this quick PR. Really appreciate it.

Btw, sorry — our translations are mostly machine translated and I admit it won't be the best. But thanks to contributors like you.

@liyasthomas liyasthomas changed the base branch from main to i18n September 6, 2021 14:53
@liyasthomas liyasthomas deleted the branch hoppscotch:i18n September 6, 2021 14:54
@liyasthomas liyasthomas closed this Sep 6, 2021
@liyasthomas liyasthomas reopened this Sep 6, 2021
@bokub
Copy link
Contributor Author

bokub commented Sep 6, 2021

You're welcome!

I know that Home Assistant (which I used to contribute to), use Lokalize to manage translations.

The free plan limit it 500 keys

You should give it a look IMO!

@liyasthomas liyasthomas changed the base branch from i18n to main September 6, 2021 14:55
@liyasthomas liyasthomas changed the base branch from main to i18n September 6, 2021 14:56
@liyasthomas liyasthomas merged commit d6d20e5 into hoppscotch:i18n Sep 6, 2021
@bokub bokub deleted the patch-1 branch September 6, 2021 14:56
@liyasthomas
Copy link
Member

liyasthomas commented Sep 6, 2021

Will definitely take a look into it. Currently, we use: GitLocalize.

Translations are updated once every week. Thanks for the PR.

@bokub
Copy link
Contributor Author

bokub commented Sep 6, 2021

Oooh, I didn't realize you were already using a tool, nevermind.

Maybe you should put a link in the app, something like "Help us translate !", and maybe not use translations made by a machine and use English as a fallback 🤷

I don't know for other languages, but for french, some buttons or links were impossible to understand, and I had to switch to English to understand what they meant 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants