Added auto theme #185
Merged
Added auto theme #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#2f1688)DeepCode analyzed this pull request. |
|
Hey @AndrewBastin, TravisBuddy Request Identifier: 1966a920-e702-11e9-8e12-4bc655cb216a |
|
I actually had one PR cooking up for this since you add Black mode. And default to auto mode seems reasonable. But after looking at the cross browser/platform support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an automatic theme which uses the
prefers-color-schememedia query to automatically go to dark mode or be in light mode respecting the user's system's norms (like Android and iOS dark modes, Windows/macOS dark modes (some change based on time of day)).Now, I do kinda feel auto to be a good candidate for being the default theme, since it integrates more with the system preference. So if this can be replaced from dark as the default, please feel free to add to my commit.